Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Reset password fixed #1083

Closed
wants to merge 1 commit into from
Closed

Bug: Reset password fixed #1083

wants to merge 1 commit into from

Conversation

BHS-Harish
Copy link
Contributor

Issue that this pull request solves

Closes: #989

Proposed changes

Reset password functionality added as per given requirement

Screenshots

bandicam.2024-07-28.19-35-11-525.mp4

@auto-assign auto-assign bot requested a review from Kajol-Kumari July 28, 2024 14:38
github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 28, 2024
View reviewed changes
backend/app/routes/Q&A/answers/updateAnswerStatus.js
const { status } = req.body;

// query fro updating
const [err, result] = await to(answers.findOneAndUpdate({ _id: id }, { $set: { isApproved: status } }));

Check failure

Code scanning / CodeQL

Database query built from user-controlled sources High

This query object depends on a
user-provided value
Loading
.
backend/app/routes/Q&A/question/updateQuestionStatus.js
const { status } = req.body;

// query fro updating
const [err, result] = await to(question.findOneAndUpdate({ _id: id }, { $set: { isApproved: status } }));

Check failure

Code scanning / CodeQL

Database query built from user-controlled sources High

This query object depends on a
user-provided value
Loading
.
backend/app/routes/admin/deleteAdmin.js

const [err, admin] = await to(Admin.findByIdAndDelete(id));
const [err, admin] = await to(Admin.findByIdAndDelete(id));

Check failure

Code scanning / CodeQL

Database query built from user-controlled sources High

This query object depends on a
user-provided value
Loading
.
backend/app/routes/broadcast/updateBroadcast.js

delete data.id;

const [err, result] = await to(Broadcast.findOneAndUpdate({ _id: req.body.id }, { $set: data }));

Check failure

Code scanning / CodeQL

Database query built from user-controlled sources High

This query object depends on a
user-provided value
Loading
.
backend/app/routes/broadcast/updateBroadcast.js

delete data.id;

const [err, result] = await to(Broadcast.findOneAndUpdate({ _id: req.body.id }, { $set: data }));

Check failure

Code scanning / CodeQL

Database query built from user-controlled sources High

This query object depends on a
user-provided value
Loading
.
backend/app/routes/joinUs/index.js

router.post('/', validation(JoinUsValidationSchema), postJoinUs);
router.get('/', authMiddleware, getJoinUs);
router.delete('/deleteJoinUs',deleteJoinUs)
router.delete('/deleteJoinUs', deleteJoinUs);

Check failure

Code scanning / CodeQL

Missing rate limiting High

This route handler performs
a database access
Loading
, but is not rate-limited.
backend/app/routes/teamMember/index.js
@@ -21,6 +21,6 @@
router.get('/getTeamMembers/', getTeamMembers);
router.get('/getTeamMember/:id', getTeamMemberById);
router.post('/addTeamMember', authMiddleware, upload.single('image'), addTeam);
router.put('/updateTeamMember',authMiddleware,upload.single('image'),updateTeamMember);
router.delete("/deleteTeamMember",authMiddleware,deleteTeamMember);
router.put('/updateTeamMember', authMiddleware, upload.single('image'), updateTeamMember);

Check failure

Code scanning / CodeQL

Missing rate limiting High

This route handler performs
authorization
Loading
, but is not rate-limited.
backend/app/routes/teamMember/index.js
@@ -21,6 +21,6 @@
router.get('/getTeamMembers/', getTeamMembers);
router.get('/getTeamMember/:id', getTeamMemberById);
router.post('/addTeamMember', authMiddleware, upload.single('image'), addTeam);
router.put('/updateTeamMember',authMiddleware,upload.single('image'),updateTeamMember);
router.delete("/deleteTeamMember",authMiddleware,deleteTeamMember);
router.put('/updateTeamMember', authMiddleware, upload.single('image'), updateTeamMember);

Check failure

Code scanning / CodeQL

Missing rate limiting High

This route handler performs
a database access
Loading
, but is not rate-limited.
This route handler performs
a database access
Loading
, but is not rate-limited.
backend/app/routes/teamMember/index.js
router.put('/updateTeamMember',authMiddleware,upload.single('image'),updateTeamMember);
router.delete("/deleteTeamMember",authMiddleware,deleteTeamMember);
router.put('/updateTeamMember', authMiddleware, upload.single('image'), updateTeamMember);
router.delete('/deleteTeamMember', authMiddleware, deleteTeamMember);

Check failure

Code scanning / CodeQL

Missing rate limiting High

This route handler performs
authorization
Loading
, but is not rate-limited.
backend/app/routes/teamMember/index.js
router.put('/updateTeamMember',authMiddleware,upload.single('image'),updateTeamMember);
router.delete("/deleteTeamMember",authMiddleware,deleteTeamMember);
router.put('/updateTeamMember', authMiddleware, upload.single('image'), updateTeamMember);
router.delete('/deleteTeamMember', authMiddleware, deleteTeamMember);

Check failure

Code scanning / CodeQL

Missing rate limiting High

This route handler performs
a database access
Loading
, but is not rate-limited.
This route handler performs
a file system access
Loading
, but is not rate-limited.
@BHS-Harish
Copy link
Contributor Author

Hey @Kajol-Kumari

Please review the request :)

Kajol-Kumari
Kajol-Kumari requested changes Jul 28, 2024
View reviewed changes
Copy link
Member

@Kajol-Kumari Kajol-Kumari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BHS-Harish

  1. 52 file changes, this pr has a lot of unnecessary changes, can u please clean it?
  2. The build is failing please fix it.

@BHS-Harish
Copy link
Contributor Author

@BHS-Harish

  1. 52 file changes, this pr has a lot of unnecessary changes, can u please clean it?
  2. The build is failing please fix it.

When i changed particular file within a folder that shows as the entire folder were changed that is the reason why 52 files were changed

@Kajol-Kumari
Copy link
Member

@BHS-Harish

  1. 52 file changes, this pr has a lot of unnecessary changes, can u please clean it?
  2. The build is failing please fix it.

When i changed particular file within a folder that shows as the entire folder were changed that is the reason why 52 files were changed

You can add particular files only under using git add <file_path1> <file_path2> ... instead of doing git add . this will avoid any unnecessary file change to come under the pr

@BHS-Harish
Copy link
Contributor Author

Okay let me close the current pr and raise new one

@BHS-Harish BHS-Harish closed this Jul 28, 2024
@BHS-Harish BHS-Harish deleted the fix-issue-989 branch July 28, 2024 17:58
@BHS-Harish BHS-Harish restored the fix-issue-989 branch July 28, 2024 18:22
@BHS-Harish BHS-Harish deleted the fix-issue-989 branch July 28, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kajol-Kumari Kajol-Kumari Kajol-Kumari requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

To Solve the bug in forgot password feature
2 participants
@BHS-Harish @Kajol-Kumari